Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider deleted string contents when updating outdated translations #40

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

hedayati-m
Copy link
Collaborator

No description provided.

@hedayati-m
Copy link
Collaborator Author

In normal case the properties, which are empty are not considered as a candidate for translation in the destination and are ignored, which is plausible. But sometimes a property is empty because it has been removed by the editor. In this case the property in destination must also be removed.

In this PL it is checked when in source language a property is empty but has a value in destination, it won't be ignored and will be translated and as a consequence is cleaned up in destination.

@mficzel mficzel merged commit 434564d into main Jan 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants